fortify scan:Weak Encryption: Insecure Mode of Operation

 Abstract:

Do not use cryptographic encryption algorithms with an insecure mode of operation.

Explanation:

The mode of operation of a block cipher is an algorithm that describes how to repeatedly apply a cipher's single-block operation to securely transform amounts of data larger than a block. Some modes of operation include Electronic Codebook (ECB), Cipher Block Chaining (CBC), Cipher Feedback (CFB), and Counter (CTR).

ECB mode is inherently weak, as it produces the same ciphertext for identical blocks of plain text. CBC mode is vulnerable to padding oracle attacks. CTR mode is the superior choice because it does not have these weaknesses.

Example 1: The following code uses the AES cipher with ECB mode:

(C#/VB.NET/ASP.NET)

  ...

  var objAesCryptoService = new AesCryptoServiceProvider();

  objAesCryptoService.Mode = CipherMode.ECB;

  objAesCryptoService.Padding = PaddingMode.PKCS7;

  objAesCryptoService.Key = securityKeyArray;

  var objCrytpoTransform = objAesCryptoService.CreateEncryptor();

  ...

(C/C++):

  ...EVP_EncryptInit_ex(&ctx, EVP_aes_256_ecb(), NULL, key, iv);

(JAVA/JSP):

...

SecretKeySpec key = new SecretKeySpec(keyBytes, "AES");

Cipher cipher = Cipher.getInstance("AES/ECB/PKCS7Padding", "BC");

cipher.init(Cipher.ENCRYPT_MODE, key);

...

Recommendations:

Avoid using ECB and CBC modes of operation when encrypting data larger than a block. CBC mode is somewhat inefficient and poses a serious risk if used with SSL [1]. Instead, use CCM (Counter with CBC-MAC) mode or, if performance is a concern, GCM (Galois/Counter Mode) mode where they are available.

Example 2: The following code uses the AES cipher with GCM mode:

  ..

  var cipher = new AesGcm(securityKeyArray)

  ...